added several errors and error stream emission #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed some style issues, changed an else to an else if
There was a problem hiding this comment.
We gotta find a better way to test for undefined...
lib/m2ts/m2ts.js
Outdated
There was a problem hiding this comment.
You could make these private-ish methods and then skip the need for self (e.g. handlePesData_ or just pes_).
|
Someone should take a look at whether the conflicts can be resolved in a reasonable amount of time (<30 min) otherwise, we should close this and perhaps schedule time to re-do it. |
|
After looking this over, I don't think we want to use this. Most of the error cases in this pull request should probably be handled, rather than having an error on them. #224 is one example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed some style issues, changed an else to an else if